net/ena: fix indication of bad L4 Rx checksums
authorIgor Chauskin <igorch@amazon.com>
Mon, 28 Oct 2019 10:23:33 +0000 (11:23 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 8 Nov 2019 22:15:04 +0000 (23:15 +0100)
Add checking of l4_csum_checked and frag flags before checking the
l4_csum_error flag.

In case of IP fragment/unchecked L4 csum - add PKT_RX_L4_CKSUM_UNKNOWN
flag to the indicated mbuf.

Fixes: 1173fca25af9 ("ena: add polling-mode driver")
Cc: stable@dpdk.org
Signed-off-by: Igor Chauskin <igorch@amazon.com>
Reviewed-by: Maciej Bielski <mba@semihalf.com>
Reviewed-by: Michal Krawczyk <mk@semihalf.com>
drivers/net/ena/ena_ethdev.c

index aa84fab..8bbd80d 100644 (file)
@@ -27,7 +27,7 @@
 
 #define DRV_MODULE_VER_MAJOR   2
 #define DRV_MODULE_VER_MINOR   0
-#define DRV_MODULE_VER_SUBMINOR        1
+#define DRV_MODULE_VER_SUBMINOR        2
 
 #define ENA_IO_TXQ_IDX(q)      (2 * (q))
 #define ENA_IO_RXQ_IDX(q)      (2 * (q) + 1)
@@ -272,8 +272,14 @@ static inline void ena_rx_mbuf_prepare(struct rte_mbuf *mbuf,
        else if (ena_rx_ctx->l3_proto == ENA_ETH_IO_L3_PROTO_IPV6)
                packet_type |= RTE_PTYPE_L3_IPV6;
 
-       if (unlikely(ena_rx_ctx->l4_csum_err))
-               ol_flags |= PKT_RX_L4_CKSUM_BAD;
+       if (!ena_rx_ctx->l4_csum_checked)
+               ol_flags |= PKT_RX_L4_CKSUM_UNKNOWN;
+       else
+               if (unlikely(ena_rx_ctx->l4_csum_err) && !ena_rx_ctx->frag)
+                       ol_flags |= PKT_RX_L4_CKSUM_BAD;
+               else
+                       ol_flags |= PKT_RX_L4_CKSUM_UNKNOWN;
+
        if (unlikely(ena_rx_ctx->l3_csum_err))
                ol_flags |= PKT_RX_IP_CKSUM_BAD;