net/bnxt: fix crash in xstats get
authorAjit Khaparde <ajit.khaparde@broadcom.com>
Wed, 13 Nov 2019 08:29:43 +0000 (13:59 +0530)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 20 Nov 2019 16:36:05 +0000 (17:36 +0100)
We would hit a segfault in bnxt_dev_xstats_get_op() if xstats argument
is NULL, Check if the argument is NULL and return appropriately.

Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
drivers/net/bnxt/bnxt_stats.c

index 40b496a..14d355f 100644 (file)
@@ -468,6 +468,9 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
        if (rc)
                return rc;
 
+       if (xstats == NULL)
+               return 0;
+
        memset(xstats, 0, sizeof(*xstats));
 
        bnxt_hwrm_port_qstats(bp);