devtools: fix symbol check for filename with space

If the patch filename or the temporary file path have a space
in their name, the script check-symbol-change.sh does not work.
The variables for the filenames must be enclosed in quotes
in order to preserve spaces.

Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Neil Horman <nhorman@tuxdriver.com>

diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 9952a8d..40b7207 100755 (executable)
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -7,7 +7,7 @@ build_map_changes()
        local fname=$1
        local mapdb=$2
 
-       cat $fname | awk '
+       cat "$fname" | awk '
                # Initialize our variables
                BEGIN {map="";sym="";ar="";sec=""; in_sec=0; in_map=0}
 
@@ -71,10 +71,10 @@ build_map_changes()
                                        print map " " sym " unknown del"
                                }
                        }
-               }' > ./$mapdb
+               }' > "$mapdb"
 
-               sort -u $mapdb > ./$mapdb.2
-               mv -f $mapdb.2 $mapdb
+               sort -u "$mapdb" > "$mapdb.2"
+               mv -f "$mapdb.2" "$mapdb"
 
 }
 
@@ -111,7 +111,7 @@ check_for_rule_violations()
                                # to be moving from an already supported
                                # section or its a violation
                                grep -q \
-                               "$mname $symname [^EXPERIMENTAL] del" $mapdb
+                               "$mname $symname [^EXPERIMENTAL] del" "$mapdb"
                                if [ $? -ne 0 ]
                                then
                                        echo -n "ERROR: symbol $symname "
@@ -133,7 +133,7 @@ check_for_rule_violations()
                                echo "gone through the deprecation process"
                        fi
                fi
-       done < $mapdb
+       done < "$mapdb"
 
        return $ret
 }
@@ -146,14 +146,14 @@ exit_code=1
 
 clean_and_exit_on_sig()
 {
-       rm -f $mapfile
+       rm -f "$mapfile"
        exit $exit_code
 }
 
-build_map_changes $patch $mapfile
-check_for_rule_violations $mapfile
+build_map_changes "$patch" "$mapfile"
+check_for_rule_violations "$mapfile"
 exit_code=$?
 
-rm -f $mapfile
+rm -f "$mapfile"
 
 exit $exit_code