vhost: declare backend with int type
authorYuanhan Liu <yuanhan.liu@linux.intel.com>
Fri, 29 Apr 2016 03:48:08 +0000 (11:48 +0800)
committerYuanhan Liu <yuanhan.liu@linux.intel.com>
Wed, 22 Jun 2016 04:10:54 +0000 (06:10 +0200)
It's an fd; so define it as "int", which could also save the unncessary
(int) case.

Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Tested-by: Rich Lane <rich.lane@bigswitch.com>
Acked-by: Rich Lane <rich.lane@bigswitch.com>
lib/librte_vhost/rte_virtio_net.h
lib/librte_vhost/virtio-net.c

index 600b20b..4d25f79 100644 (file)
@@ -85,7 +85,7 @@ struct vhost_virtqueue {
        struct vring_avail      *avail;                 /**< Virtqueue available ring. */
        struct vring_used       *used;                  /**< Virtqueue used ring. */
        uint32_t                size;                   /**< Size of descriptor ring. */
-       uint32_t                backend;                /**< Backend value to determine if device should started/stopped. */
+       int                     backend;                /**< Backend value to determine if device should started/stopped. */
        uint16_t                vhost_hlen;             /**< Vhost header length (varies depending on RX merge buffers. */
        volatile uint16_t       last_used_idx;          /**< Last index used on the available ring */
        volatile uint16_t       last_used_idx_res;      /**< Used for multiple devices reserving buffers. */
index f4695af..1a6259b 100644 (file)
@@ -717,8 +717,8 @@ vhost_set_backend(struct vhost_device_ctx ctx, struct vhost_vring_file *file)
         * we add the device.
         */
        if (!(dev->flags & VIRTIO_DEV_RUNNING)) {
-               if (((int)dev->virtqueue[VIRTIO_TXQ]->backend != VIRTIO_DEV_STOPPED) &&
-                       ((int)dev->virtqueue[VIRTIO_RXQ]->backend != VIRTIO_DEV_STOPPED)) {
+               if (dev->virtqueue[VIRTIO_TXQ]->backend != VIRTIO_DEV_STOPPED &&
+                   dev->virtqueue[VIRTIO_RXQ]->backend != VIRTIO_DEV_STOPPED) {
                        return notify_ops->new_device(dev);
                }
        /* Otherwise we remove it. */