]> git.droids-corp.org - dpdk.git/commitdiff
raw/ifpga: fix integer overflow for N3000
authorWei Huang <wei.huang@intel.com>
Thu, 23 Jun 2022 03:11:40 +0000 (23:11 -0400)
committerThomas Monjalon <thomas@monjalon.net>
Sun, 26 Jun 2022 10:20:25 +0000 (12:20 +0200)
Expression "tx_chunks * ctx->dma_buf_size" in dma_fpga_to_fpga()
is evaluated using 32-bit arithmetic, which would overflow
 potentially. Change tx_chunks to type "uint64_t" to avoid such
issue.

Coverity issue: 379203
Fixes: 7d63899a5c19 ("raw/ifpga: add N3000 AFU driver")
Signed-off-by: Wei Huang <wei.huang@intel.com>
Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
drivers/raw/ifpga/afu_pmd_n3000.c

index 870816448549c79d73933164a278a0029bb411ab..5120df5f77c524cc38dd5e41ed7ddbeefe659972 100644 (file)
@@ -1158,7 +1158,7 @@ static int dma_fpga_to_fpga(struct dma_afu_ctx *ctx, uint64_t dst, uint64_t src,
        uint64_t count_left = count;
        uint64_t dma_chunks = 0;
        uint64_t offset = 0;
-       uint32_t tx_chunks = 0;
+       uint64_t tx_chunks = 0;
        uint64_t *tmp_buf = NULL;
        int ret = 0;
 
@@ -1213,7 +1213,7 @@ static int dma_fpga_to_fpga(struct dma_afu_ctx *ctx, uint64_t dst, uint64_t src,
                offset = tx_chunks * ctx->dma_buf_size;
                count_left -= offset;
                IFPGA_RAWDEV_PMD_DEBUG("0x%"PRIx64" --> 0x%"PRIx64
-                       " (%u...0x%"PRIx64")",
+                       " (%"PRIu64"...0x%"PRIx64")",
                        src, dst, tx_chunks, count_left);
                tmp_buf = (uint64_t *)rte_malloc(NULL, ctx->dma_buf_size,
                        DMA_ALIGN_BYTES);