cmdline: avoid garbage in unused fields of parsed result
authorXueming Li <xuemingl@mellanox.com>
Sat, 20 Jan 2018 03:26:31 +0000 (11:26 +0800)
committerThomas Monjalon <thomas@monjalon.net>
Thu, 25 Jan 2018 22:16:53 +0000 (23:16 +0100)
The result buffer was not initialized before parsing, inducing garbage
in unused fields or padding of the parsed structure.

Initialize the result buffer each time before parsing.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
lib/librte_cmdline/cmdline_parse.c

index c74b146..7f799f9 100644 (file)
@@ -168,6 +168,8 @@ match_inst(cmdline_parse_inst_t *inst, const char *buf,
        int n = 0;
        struct cmdline_token_hdr token_hdr;
 
+       if (resbuf != NULL)
+               memset(resbuf, 0, resbuf_size);
        /* check if we match all tokens of inst */
        while (!nb_match_token || i < nb_match_token) {
                token_p = get_token(inst, i);