app/testpmd: use port sibling iterator in device cleanup
authorThomas Monjalon <thomas@monjalon.net>
Mon, 1 Apr 2019 02:27:00 +0000 (04:27 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 5 Apr 2019 15:45:22 +0000 (17:45 +0200)
When removing a rte_device on a port-based request,
all the sibling ports must be marked as closed.
The iterator loop can be simplified by using the dedicated macro.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tested-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
app/test-pmd/testpmd.c

index 40c873b..aeaa74c 100644 (file)
@@ -2370,9 +2370,7 @@ detach_port_device(portid_t port_id)
                return;
        }
 
-       for (sibling = 0; sibling < RTE_MAX_ETHPORTS; sibling++) {
-               if (rte_eth_devices[sibling].device != dev)
-                       continue;
+       RTE_ETH_FOREACH_DEV_SIBLING(sibling, port_id) {
                /* reset mapping between old ports and removed device */
                rte_eth_devices[sibling].device = NULL;
                if (ports[sibling].port_status != RTE_PORT_CLOSED) {