net/ice: correct key length and queues check for RSS
authorSimei Su <simei.su@intel.com>
Wed, 30 Oct 2019 02:52:25 +0000 (10:52 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 8 Nov 2019 22:15:04 +0000 (23:15 +0100)
This patch corrects key_len and queues check. The key_len and queues
are not supported to configure for RSS in rte_flow.

Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")

Signed-off-by: Simei Su <simei.su@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
drivers/net/ice/ice_hash.c

index 346d6cf..3381b45 100644 (file)
@@ -25,8 +25,6 @@
 #include "ice_ethdev.h"
 #include "ice_generic_flow.h"
 
-#define ICE_ACTION_RSS_MAX_QUEUE_NUM 32
-
 struct rss_type_match_hdr {
        uint32_t hdr_mask;
        uint64_t eth_rss_hint;
@@ -333,15 +331,15 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
                                        RTE_FLOW_ERROR_TYPE_ACTION, action,
                                        "a nonzero RSS encapsulation level is not supported");
 
-                       if (rss->key_len == 0)
+                       if (rss->key_len)
                                return rte_flow_error_set(error, ENOTSUP,
                                        RTE_FLOW_ERROR_TYPE_ACTION, action,
-                                       "RSS hash key_len mustn't be 0");
+                                       "a nonzero RSS key_len is not supported");
 
-                       if (rss->queue_num > ICE_ACTION_RSS_MAX_QUEUE_NUM)
+                       if (rss->queue)
                                return rte_flow_error_set(error, ENOTSUP,
                                        RTE_FLOW_ERROR_TYPE_ACTION, action,
-                                       "too many queues for RSS context");
+                                       "a non-NULL RSS queue is not supported");
 
                        /* Check hash function and save it to rss_meta. */
                        if (rss->func ==