examples: remove useless null checks before rte_free
authorStephen Hemminger <stephen@networkplumber.org>
Tue, 7 Apr 2015 21:21:00 +0000 (14:21 -0700)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Mon, 13 Apr 2015 20:50:10 +0000 (22:50 +0200)
rte_free handles getting passed a NULL pointer.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
examples/vhost/main.c
examples/vhost_xen/vhost_monitor.c
examples/vm_power_manager/channel_manager.c

index c3fcb80..ad10f82 100644 (file)
@@ -2747,8 +2747,7 @@ new_device (struct virtio_net *dev)
                RTE_LOG(INFO, VHOST_DATA, "(%"PRIu64") Failed to add device to data core\n", dev->device_fh);
                vdev->ready = DEVICE_SAFE_REMOVE;
                destroy_device(dev);
-               if (vdev->regions_hpa)
-                       rte_free(vdev->regions_hpa);
+               rte_free(vdev->regions_hpa);
                rte_free(vdev);
                return -1;
        }
index 9d99962..6455993 100644 (file)
@@ -298,10 +298,9 @@ virtio_net_config_ll *new_device(unsigned int virtio_idx, struct xen_guest *gues
 err:
        if (new_ll_dev)
                free(new_ll_dev);
-       if (virtqueue_rx)
-               rte_free(virtqueue_rx);
-       if (virtqueue_tx)
-               rte_free(virtqueue_tx);
+       rte_free(virtqueue_rx);
+       rte_free(virtqueue_tx);
+
        return NULL;
 }
 
index 04344ae..7d892e2 100644 (file)
@@ -800,9 +800,7 @@ channel_manager_exit(void)
                rte_free(vm_info);
        }
 
-       if (global_cpumaps != NULL)
-               rte_free(global_cpumaps);
-       if (global_vircpuinfo != NULL)
-               rte_free(global_vircpuinfo);
+       rte_free(global_cpumaps);
+       rte_free(global_vircpuinfo);
        disconnect_hypervisor();
 }