mem: fix variable shadowing
authorAnatoly Burakov <anatoly.burakov@intel.com>
Tue, 8 Jan 2019 16:33:59 +0000 (16:33 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Mon, 14 Jan 2019 14:42:40 +0000 (15:42 +0100)
A local variable ``flags`` was shadowing another variable from outer
scope. Fix this by renaming the variable and make it const.

Fixes: c127be93f619 ("mem: support using memfd segments for in-memory mode")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
lib/librte_eal/linuxapp/eal/eal_memalloc.c

index 60a0a68..5b421f1 100644 (file)
@@ -621,13 +621,13 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
        int mmap_flags;
 
        if (internal_config.in_memory && !memfd_create_supported) {
-               int pagesz_flag, flags;
+               const int in_memory_flags = MAP_HUGETLB | MAP_FIXED |
+                               MAP_PRIVATE | MAP_ANONYMOUS;
+               int pagesz_flag;
 
                pagesz_flag = pagesz_flags(alloc_sz);
-               flags = pagesz_flag | MAP_HUGETLB | MAP_FIXED |
-                               MAP_PRIVATE | MAP_ANONYMOUS;
                fd = -1;
-               mmap_flags = flags;
+               mmap_flags = in_memory_flags | pagesz_flag;
 
                /* single-file segments codepath will never be active
                 * here because in-memory mode is incompatible with the