eal: make the -n argument optional
authorPanu Matilainen <pmatilai@redhat.com>
Thu, 15 Oct 2015 11:49:05 +0000 (14:49 +0300)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Mon, 26 Oct 2015 16:50:27 +0000 (17:50 +0100)
Obtaining the correct value of memory channels, especially from a
running system, can be anything from difficult to plain impossible.
Since the value is merely an optimization and does not affect functionality
otherwise, its pointless to force such a guess on users initially, such
things belong to performance tuning phase.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
Acked-by: David Marchand <david.marchand@6wind.com>
lib/librte_eal/common/eal_common_options.c

index 1f459ac..a4cdbaa 100644 (file)
@@ -834,12 +834,6 @@ eal_check_common_options(struct internal_config *internal_cfg)
                RTE_LOG(ERR, EAL, "Invalid process type specified\n");
                return -1;
        }
-       if (internal_cfg->process_type == RTE_PROC_PRIMARY &&
-                       internal_cfg->force_nchannel == 0) {
-               RTE_LOG(ERR, EAL, "Number of memory channels (-n) not "
-                       "specified\n");
-               return -1;
-       }
        if (index(internal_cfg->hugefile_prefix, '%') != NULL) {
                RTE_LOG(ERR, EAL, "Invalid char, '%%', in --"OPT_FILE_PREFIX" "
                        "option\n");
@@ -869,7 +863,7 @@ eal_check_common_options(struct internal_config *internal_cfg)
 void
 eal_common_usage(void)
 {
-       printf("-c COREMASK|-l CORELIST -n CHANNELS [options]\n\n"
+       printf("-c COREMASK|-l CORELIST [options]\n\n"
               "EAL common options:\n"
               "  -c COREMASK         Hexadecimal bitmask of cores to run on\n"
               "  -l CORELIST         List of cores to run on\n"