net/pcap: fix memory leak in jumbo frames
authorDror Birkman <dror.birkman@lightcyber.com>
Tue, 20 Sep 2016 12:08:56 +0000 (15:08 +0300)
committerBruce Richardson <bruce.richardson@intel.com>
Fri, 30 Sep 2016 10:27:18 +0000 (12:27 +0200)
If rte_pktmbuf_alloc() fails on any segment that is not the initial
segment, previously allocated mbufs are not freed.

Fixes: 6db141c91e1f ("pcap: support jumbo frames")

Signed-off-by: Dror Birkman <dror.birkman@lightcyber.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
drivers/net/pcap/rte_eth_pcap.c

index 48d96fa..51ef86f 100644 (file)
@@ -222,8 +222,10 @@ eth_pcap_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
                        if (unlikely(eth_pcap_rx_jumbo(pcap_q->mb_pool,
                                                       mbuf,
                                                       packet,
-                                                      header.caplen) == -1))
+                                                      header.caplen) == -1)) {
+                               rte_pktmbuf_free(mbuf);
                                break;
+                       }
                }
 
                mbuf->pkt_len = (uint16_t)header.caplen;