compress/isal: add appropriate flag on overflow
authorLee Daly <lee.daly@intel.com>
Thu, 24 Jan 2019 15:19:13 +0000 (15:19 +0000)
committerAkhil Goyal <akhil.goyal@nxp.com>
Tue, 2 Apr 2019 14:50:24 +0000 (16:50 +0200)
This patch will change the operation status when ISA-L returns because
of a recoverable out of space error, rather than a just generic fail.

Signed-off-by: Lee Daly <lee.daly@intel.com>
Tested-by: Tomasz Cel <tomaszx.cel@intel.com>
drivers/compress/isal/isal_compress_pmd.c

index ca1d703..7d2b05c 100644 (file)
@@ -354,12 +354,6 @@ chained_mbuf_decompression(struct rte_comp_op *op, struct isal_comp_qp *qp)
 
                ret = isal_inflate(qp->state);
 
-               if (ret != ISAL_DECOMP_OK) {
-                       ISAL_PMD_LOG(ERR, "Decompression operation failed\n");
-                       op->status = RTE_COMP_OP_STATUS_ERROR;
-                       return ret;
-               }
-
                /* Check for first segment, offset needs to be accounted for */
                if (remaining_data == op->src.length) {
                        consumed_data = src->data_len - src_remaining_offset;
@@ -380,6 +374,20 @@ chained_mbuf_decompression(struct rte_comp_op *op, struct isal_comp_qp *qp)
                        }
                }
 
+               if (ret == ISAL_OUT_OVERFLOW) {
+                       ISAL_PMD_LOG(ERR, "Decompression operation ran "
+                               "out of space, but can be recovered.\n%d bytes "
+                               "consumed\t%d bytes produced\n",
+                               consumed_data, qp->state->total_out);
+                               op->status =
+                               RTE_COMP_OP_STATUS_OUT_OF_SPACE_RECOVERABLE;
+                       return ret;
+               } else if (ret < 0) {
+                       ISAL_PMD_LOG(ERR, "Decompression operation failed\n");
+                       op->status = RTE_COMP_OP_STATUS_ERROR;
+                       return ret;
+               }
+
                if (qp->state->avail_out == 0 &&
                                qp->state->block_state != ISAL_BLOCK_FINISH) {
                        if (dst->next != NULL) {