net/ring: avoid hard-coded length
authorStephen Hemminger <stephen@networkplumber.org>
Tue, 23 Apr 2019 16:53:33 +0000 (09:53 -0700)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 3 May 2019 16:45:23 +0000 (18:45 +0200)
Don't hard code string length in two place; use sizeof() instead.
Ring name should use RTE_RING_NAMESIZE.

Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
drivers/net/ring/rte_eth_ring.c

index 91e5f5f..2e4ca3b 100644 (file)
@@ -362,8 +362,8 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
                .numa_node = numa_node,
                .addr = &args,
        };
-       char args_str[32] = { 0 };
-       char ring_name[32] = { 0 };
+       char args_str[32];
+       char ring_name[RTE_RING_NAMESIZE];
        uint16_t port_id = RTE_MAX_ETHPORTS;
        int ret;
 
@@ -381,8 +381,9 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],
                return -1;
        }
 
-       snprintf(args_str, 32, "%s=%p", ETH_RING_INTERNAL_ARG, &args);
-       snprintf(ring_name, 32, "net_ring_%s", name);
+       snprintf(args_str, sizeof(args_str), "%s=%p",
+                ETH_RING_INTERNAL_ARG, &args);
+       snprintf(ring_name, sizeof(ring_name), "net_ring_%s", name);
 
        ret = rte_vdev_init(ring_name, args_str);
        if (ret) {