net/bonding: fix slave stop and remove on port close
authorHuisong Li <lihuisong@huawei.com>
Tue, 3 May 2022 10:02:14 +0000 (18:02 +0800)
committerFerruh Yigit <ferruh.yigit@xilinx.com>
Wed, 11 May 2022 12:48:16 +0000 (14:48 +0200)
All slaves will be stopped and removed when closing a bonded port.
But the while loop can not end if both rte_eth_dev_stop and
rte_eth_bond_slave_remove fails, runs infinitely.
This is because the skipped slave port counted in both function failures
but it should be counted only one.

Fixing by not continue to process in the loop after first failure.

Fixes: fb0379bc5db3 ("net/bonding: check stop call status")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
drivers/net/bonding/rte_eth_bond_pmd.c

index 605fc2f..f0668a6 100644 (file)
@@ -2156,6 +2156,7 @@ bond_ethdev_close(struct rte_eth_dev *dev)
                        RTE_BOND_LOG(ERR, "Failed to stop device on port %u",
                                     port_id);
                        skipped++;
+                       continue;
                }
 
                if (rte_eth_bond_slave_remove(bond_port_id, port_id) != 0) {