crypto/armv8: remove redundant assert definition
authorRuifeng Wang <ruifeng.wang@arm.com>
Tue, 28 Jul 2020 09:24:06 +0000 (17:24 +0800)
committerAkhil Goyal <akhil.goyal@nxp.com>
Tue, 28 Jul 2020 20:09:22 +0000 (22:09 +0200)
No need to define assert function in PMD since RTE provides the same.
Remove private definition and use RTE_VERIFY instead.

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
drivers/crypto/armv8/armv8_pmd_private.h
drivers/crypto/armv8/rte_armv8_pmd.c

index 709b3d5..66b03fb 100644 (file)
@@ -30,14 +30,6 @@ extern int crypto_armv8_log_type;
                        RTE_STR(CRYPTODEV_NAME_ARMV8_PMD),      \
                        __func__, __LINE__, ## args)
 
-#define ARMV8_CRYPTO_ASSERT(con)                               \
-do {                                                           \
-       if (!(con)) {                                           \
-               rte_panic("condition failed, line %u",          \
-                       __LINE__);                              \
-       }                                                       \
-} while (0)
-
 #define NBBY           8               /* Number of bits in a byte */
 #define BYTE_LENGTH(x) ((x) / NBBY)    /* Number of bytes in x (round down) */
 
index a2b08d8..c95729d 100644 (file)
@@ -630,7 +630,7 @@ process_armv8_chained_op(struct armv8_crypto_qp *qp, struct rte_crypto_op *op,
        arg.cipher.key = sess->cipher.key.data;
        /* Acquire combined mode function */
        crypto_func = sess->crypto_func;
-       ARMV8_CRYPTO_ASSERT(crypto_func != NULL);
+       RTE_VERIFY(crypto_func != NULL);
        error = crypto_func(csrc, cdst, clen, asrc, adst, alen, &arg);
        if (error != 0) {
                op->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;