net/i40e: fix max frame size config at port level

Previously, max frame size can only be set when link is up, and the wait
time is 1 sec. Startup time of 10G_BASET longer than 1s would result in
failure.

Actually, max frame size of media type I40E_MEDIA_TYPE_BASET can be set
regardless of link status.

This patch omitted the link status check of 10G_MEDIA_TYPE_BASET.

Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level")
Cc: stable@dpdk.org
Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
Acked-by: Yuying Zhang <yuying.zhang@intel.com>

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 755786dc1006b096d4ac535dc4e39cc58a95c00f..7ffd7e7384110e44dfb1932056c2a284439ca4d8 100644 (file)
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12103,16 +12103,20 @@ i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size)
        uint32_t rep_cnt = MAX_REPEAT_TIME;
        struct rte_eth_link link;
        enum i40e_status_code status;
+       bool can_be_set = true;
 
-       do {
-               update_link_reg(hw, &link);
-               if (link.link_status)
-                       break;
-
-               rte_delay_ms(CHECK_INTERVAL);
-       } while (--rep_cnt);
+       /* I40E_MEDIA_TYPE_BASET link up can be ignored */
+       if (hw->phy.media_type != I40E_MEDIA_TYPE_BASET) {
+               do {
+                       update_link_reg(hw, &link);
+                       if (link.link_status)
+                               break;
+                       rte_delay_ms(CHECK_INTERVAL);
+               } while (--rep_cnt);
+               can_be_set = !!link.link_status;
+       }
 
-       if (link.link_status) {
+       if (can_be_set) {
                status = i40e_aq_set_mac_config(hw, size, TRUE, 0, false, NULL);
                if (status != I40E_SUCCESS)
                        PMD_DRV_LOG(ERR, "Failed to set max frame size at port level");