]> git.droids-corp.org - dpdk.git/commitdiff
app/flow-perf: fix parsing of invalid option
authorRaslan Darawsheh <rasland@nvidia.com>
Tue, 16 Nov 2021 14:12:26 +0000 (16:12 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 17 Nov 2021 09:47:55 +0000 (10:47 +0100)
Currently, if an invalid parameter is passed to the application
it will cause a crash due to missing default in options.

For example:
        ./dpdk-test-flow-perf -a 01:00.0 -- --invalid

This adds missing default for options, and prints the
invalid option.

Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton")
Cc: stable@dpdk.org
Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
Acked-by: Wisam Jaddo <wisamm@nvidia.com>
app/test-flow-perf/main.c

index 2b612aa32cd9af0e8650b220eafad1992c937013..11f1ee0e1e5e8fe192190ecd25c78384352d49cf 100644 (file)
@@ -715,6 +715,7 @@ args_parse(int argc, char **argv)
                { "policy-mtr",                 1, 0, 0 },
                { "meter-profile",              1, 0, 0 },
                { "packet-mode",                0, 0, 0 },
+               { 0, 0, 0, 0 },
        };
 
        RTE_ETH_FOREACH_DEV(i)
@@ -951,7 +952,7 @@ args_parse(int argc, char **argv)
                default:
                        usage(argv[0]);
                        rte_exit(EXIT_FAILURE, "Invalid option: %s\n",
-                                       argv[optind]);
+                                       argv[optind - 1]);
                        break;
                }
        }