net/thunderx: fix crash on detach
authorAmit Gupta <agupta3@marvell.com>
Mon, 5 Aug 2019 08:00:44 +0000 (13:30 +0530)
committerJerin Jacob <jerinj@marvell.com>
Mon, 5 Aug 2019 17:03:01 +0000 (19:03 +0200)
Fix the PCIe detach segfault by releasing eth_dev resources
by adding nicvf cleanup support on PCI detach.

Fixes: fdf91e0f2fac ("drivers/net: do not use ethdev driver")
Cc: stable@dpdk.org
Signed-off-by: Amit Gupta <agupta3@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
drivers/net/thunderx/nicvf_ethdev.c

index ec57692..56769ef 100644 (file)
@@ -2083,6 +2083,16 @@ kvlist_free:
        return ret;
 }
 static int
+nicvf_eth_dev_uninit(struct rte_eth_dev *dev)
+{
+       PMD_INIT_FUNC_TRACE();
+
+       if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+               nicvf_dev_close(dev);
+
+       return 0;
+}
+static int
 nicvf_eth_dev_init(struct rte_eth_dev *eth_dev)
 {
        int ret;
@@ -2256,7 +2266,7 @@ static int nicvf_eth_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 
 static int nicvf_eth_pci_remove(struct rte_pci_device *pci_dev)
 {
-       return rte_eth_dev_pci_generic_remove(pci_dev, NULL);
+       return rte_eth_dev_pci_generic_remove(pci_dev, nicvf_eth_dev_uninit);
 }
 
 static struct rte_pci_driver rte_nicvf_pmd = {