net/bnxt: set flow error after tunnel redirection free
authorKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Mon, 31 May 2021 07:26:40 +0000 (12:56 +0530)
committerAjit Khaparde <ajit.khaparde@broadcom.com>
Tue, 8 Jun 2021 22:26:57 +0000 (00:26 +0200)
During flow destroy, when bnxt_hwrm_tunnel_redirect_free() fails,
driver is not setting flow error using "rte_flow_error_set".

Fixes: 11e5e19695c7 ("net/bnxt: support redirecting tunnel packets to VF")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
drivers/net/bnxt/bnxt_flow.c

index 03c7173..ed201a3 100644 (file)
@@ -1969,12 +1969,20 @@ static int bnxt_handle_tunnel_redirect_destroy(struct bnxt *bp,
                /* Tunnel doesn't belong to this VF, so don't send HWRM
                 * cmd, just delete the flow from driver
                 */
-               if (bp->fw_fid != (tun_dst_fid + bp->first_vf_id))
+               if (bp->fw_fid != (tun_dst_fid + bp->first_vf_id)) {
                        PMD_DRV_LOG(ERR,
                                    "Tunnel does not belong to this VF, skip hwrm_tunnel_redirect_free\n");
-               else
+               } else {
                        ret = bnxt_hwrm_tunnel_redirect_free(bp,
                                                        filter->tunnel_type);
+                       if (ret) {
+                               rte_flow_error_set(error, -ret,
+                                                  RTE_FLOW_ERROR_TYPE_HANDLE,
+                                                  NULL,
+                                                  "Unable to free tunnel redirection");
+                               return ret;
+                       }
+               }
        }
        return ret;
 }