net/ice/base: fix symmetric hash configure
authorQi Zhang <qi.z.zhang@intel.com>
Thu, 31 Oct 2019 03:55:21 +0000 (11:55 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 8 Nov 2019 22:15:04 +0000 (23:15 +0100)
When a new hash profile is created, we need to reset all related
GLQF_HSYMM registers, otherwise unexpected hash behaviour may happen
on packet that hits that profile.

The patch fixes the issue that we only do reset when symmetric hash
is required, but actually for non symmetric hash we also need this,
since GLQF_HSYMM might be polluted by previous configuration.

Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS")

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Tested-by: Simei Su <simei.su@intel.com>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
drivers/net/ice/base/ice_flow.c

index 6264e77..391df1b 100644 (file)
@@ -2191,8 +2191,6 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds,
        status = ice_add_rss_list(hw, vsi_handle, prof);
 
        prof->cfg.symm = symm;
-       if (!symm)
-               goto exit;
 
 update_symm:
        ice_rss_update_symm(hw, prof);