app/test: fix misplaced braces in devargs check
authorBruce Richardson <bruce.richardson@intel.com>
Wed, 19 Nov 2014 09:06:13 +0000 (09:06 +0000)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Mon, 24 Nov 2014 15:28:43 +0000 (16:28 +0100)
This patch fixes two occurrences where a call to strncmp had the closing
brace in the wrong place. Changing this form:
if (strncmp(X,Y,sizeof(X) != 0))
which does a comparison of length 1, to
if (strncmp(X,Y,sizeof(X)) != 0)
which does the correct length comparison and then compares the result to
zero in the "if" part, as the author presumably originally intended.

Reported-by: Larry Wang <liang-min.wang@intel.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
app/test/test_devargs.c

index f0acf8e..dcbdd09 100644 (file)
@@ -90,9 +90,9 @@ test_devargs(void)
                goto fail;
        devargs = TAILQ_FIRST(&devargs_list);
        if (strncmp(devargs->virtual.drv_name, "eth_ring1",
-                       sizeof(devargs->virtual.drv_name) != 0))
+                       sizeof(devargs->virtual.drv_name)) != 0)
                goto fail;
-       if (strncmp(devargs->args, "k1=val,k2=val2", sizeof(devargs->args) != 0))
+       if (strncmp(devargs->args, "k1=val,k2=val2", sizeof(devargs->args)) != 0)
                goto fail;
        free_devargs_list();