test/power: check all environment types

Test all existing power environment configuration to verify if related
data is properly initialized and clean in set/unset scenarios.

Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

diff --git a/app/test/test_power.c b/app/test/test_power.c
index a0ee219..0ff2aa0 100644 (file)
--- a/app/test/test_power.c
+++ b/app/test/test_power.c
@@ -7,6 +7,7 @@
 #include <unistd.h>
 #include <limits.h>
 #include <string.h>
+#include <stdbool.h>
 
 #include "test.h"
 
@@ -23,6 +24,86 @@ test_power(void)
 
 #include <rte_power.h>
 
+static int
+check_function_ptrs(void)
+{
+       enum power_management_env env = rte_power_get_env();
+
+       const bool not_null_expected = !(env == PM_ENV_NOT_SET);
+
+       const char *inject_not_string1 = not_null_expected ? " not" : "";
+       const char *inject_not_string2 = not_null_expected ? "" : " not";
+
+       if ((rte_power_freqs == NULL) == not_null_expected) {
+               printf("rte_power_freqs should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                                       inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_get_freq == NULL) == not_null_expected) {
+               printf("rte_power_get_freq should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                                       inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_set_freq == NULL) == not_null_expected) {
+               printf("rte_power_set_freq should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_freq_up == NULL) == not_null_expected) {
+               printf("rte_power_freq_up should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_freq_down == NULL) == not_null_expected) {
+               printf("rte_power_freq_down should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_freq_max == NULL) == not_null_expected) {
+               printf("rte_power_freq_max should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_freq_min == NULL) == not_null_expected) {
+               printf("rte_power_freq_min should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_turbo_status == NULL) == not_null_expected) {
+               printf("rte_power_turbo_status should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_freq_enable_turbo == NULL) == not_null_expected) {
+               printf("rte_power_freq_enable_turbo should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_freq_disable_turbo == NULL) == not_null_expected) {
+               printf("rte_power_freq_disable_turbo should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+       if ((rte_power_get_capabilities == NULL) == not_null_expected) {
+               printf("rte_power_get_capabilities should%s be NULL, environment has%s been "
+                               "initialised\n", inject_not_string1,
+                               inject_not_string2);
+               return -1;
+       }
+
+       return 0;
+}
+
 static int
 test_power(void)
 {
@@ -43,43 +124,48 @@ test_power(void)
                return -1;
        }
 
-       /* verify that function pointers are NULL */
-       if (rte_power_freqs != NULL) {
-               printf("rte_power_freqs should be NULL, environment has not been "
-                               "initialised\n");
-               goto fail_all;
-       }
-       if (rte_power_get_freq != NULL) {
-               printf("rte_power_get_freq should be NULL, environment has not been "
-                               "initialised\n");
-               goto fail_all;
-       }
-       if (rte_power_set_freq != NULL) {
-               printf("rte_power_set_freq should be NULL, environment has not been "
-                               "initialised\n");
-               goto fail_all;
-       }
-       if (rte_power_freq_up != NULL) {
-               printf("rte_power_freq_up should be NULL, environment has not been "
-                               "initialised\n");
-               goto fail_all;
-       }
-       if (rte_power_freq_down != NULL) {
-               printf("rte_power_freq_down should be NULL, environment has not been "
-                               "initialised\n");
-               goto fail_all;
-       }
-       if (rte_power_freq_max != NULL) {
-               printf("rte_power_freq_max should be NULL, environment has not been "
-                               "initialised\n");
-               goto fail_all;
-       }
-       if (rte_power_freq_min != NULL) {
-               printf("rte_power_freq_min should be NULL, environment has not been "
-                               "initialised\n");
+       /* Verify that function pointers are NULL */
+       if (check_function_ptrs() < 0)
                goto fail_all;
-       }
+
        rte_power_unset_env();
+
+       /* Perform tests for valid environments.*/
+       const enum power_management_env envs[] = {PM_ENV_ACPI_CPUFREQ,
+                       PM_ENV_KVM_VM,
+                       PM_ENV_PSTATE_CPUFREQ};
+
+       const int envs_size = sizeof(envs)/sizeof(enum power_management_env);
+
+       int i;
+       for (i = 0; i < envs_size; ++i) {
+
+               /* Test setting a valid environment */
+               ret = rte_power_set_env(envs[i]);
+               if (ret != 0) {
+                       printf("Unexpectedly unsucceeded on setting a valid environment\n");
+                       return -1;
+               }
+
+               /* Test that the environment has been set */
+               env = rte_power_get_env();
+               if (env != envs[i]) {
+                       printf("Not expected environment configuration\n");
+                       return -1;
+               }
+
+               /* Verify that function pointers are NOT NULL */
+               if (check_function_ptrs() < 0)
+                       goto fail_all;
+
+               rte_power_unset_env();
+
+               /* Verify that function pointers are NULL */
+               if (check_function_ptrs() < 0)
+                       goto fail_all;
+
+       }
+
        return 0;
 fail_all:
        rte_power_unset_env();