]> git.droids-corp.org - dpdk.git/commitdiff
net/bnxt: fix flow RSS failure handling
authorKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Thu, 28 Oct 2021 02:29:44 +0000 (07:59 +0530)
committerAjit Khaparde <ajit.khaparde@broadcom.com>
Thu, 28 Oct 2021 04:23:11 +0000 (06:23 +0200)
With commit 239695f754cb ("net/bnxt: enhance RSS action support"),
when bnxt_hwrm_vnic_rss_cfg() call fails, driver was not setting
flow error using "rte_flow_error_set".

Fixes: 239695f754cb ("net/bnxt: enhance RSS action support")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
drivers/net/bnxt/bnxt_flow.c

index 09b134253377f2253657661e9fabc99b73874015..d062be5525809fcbe2ca771713b003face9570ea 100644 (file)
@@ -1226,6 +1226,15 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,
 
 skip_rss_table:
        rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
+       if (rc != 0) {
+               rte_flow_error_set(error,
+                                  -rc,
+                                  RTE_FLOW_ERROR_TYPE_ACTION,
+                                  act,
+                                  "VNIC RSS configure failed");
+               rc = -rte_errno;
+               goto ret;
+       }
 ret:
        return rc;
 }
@@ -1515,7 +1524,7 @@ skip_vnic_alloc:
                        /* RSS config update requested */
                        rc = bnxt_vnic_rss_cfg_update(bp, vnic, act, error);
                        if (rc != 0)
-                               return -rte_errno;
+                               goto ret;
 
                        filter->dst_id = vnic->fw_vnic_id;
                        break;