devargs: fix leak on hotplug failure

Caught by ASan, if a secondary process tried to attach a device with an
incorrect driver name, devargs was leaked.

Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>

diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c
index c0ee4e442f4385a4da9eff182d07cc270cf72d59..9d913e54781536cea836c4dcc3d06b6c14fcb266 100644 (file)
--- a/lib/eal/common/eal_common_dev.c
+++ b/lib/eal/common/eal_common_dev.c
@@ -180,8 +180,10 @@ local_dev_probe(const char *devargs, struct rte_device **new_dev)
        return ret;
 
 err_devarg:
-       if (rte_devargs_remove(da) != 0)
+       if (rte_devargs_remove(da) != 0) {
                rte_devargs_reset(da);
+               free(da);
+       }
        return ret;
 }