net/i40e: set VF TC max bandwidth from PF

Set a specific TC's max bandwidth on a VF.
User can call the API to set VF TC's max bandwidth
from PF.

Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 043de348e3b99a5a045f96319009627e3bcbb029..c265e895c8da6f8b11e993320f7d37ddb0cb26cf 100644 (file)
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -467,3 +467,14 @@ Incorrect Rx statistics when packet is oversize
 When a packet is over maximum frame size, the packet is dropped.
 However the Rx statistics, when calling `rte_eth_stats_get` incorrectly
 shows it as received.
+
+VF & TC max bandwidth setting
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The per VF max bandwidth and per TC max bandwidth cannot be enabled in parallel.
+The dehavior is different when handling per VF and per TC max bandwidth setting.
+When enabling per VF max bandwidth, SW will check if per TC max bandwidth is
+enabled. If so, return failure.
+When enabling per TC max bandwidth, SW will check if per VF max bandwidth
+is enabled. If so, disable per VF max bandwidth and continue with per TC max
+bandwidth setting.

diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst
index f5ace5e53cf87519b91624ed6139154173a7503a..5573dbe5953ddac31a4fa7806a8358286d22f609 100644 (file)
--- a/doc/guides/rel_notes/release_17_05.rst
+++ b/doc/guides/rel_notes/release_17_05.rst
@@ -88,6 +88,11 @@ New Features
   i40e HW supports to set the allocated bandwidth for a TC on a VF. Enable this
   capability.
 
+* **Added VF TC max bandwidth setting on i40e.**
+
+  i40e HW supports to set the max bandwidth for a TC on a VF. Enable this
+  capability.
+
 * **Added TSO support for tunneled and non-tunneled packets on mlx5 driver.**
 
   Added support for Hardware TSO for tunneled and non-tunneled packets.

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index cf89882a99527432433659eb5a79ad84bf8484d1..deff3acddb5bedf1f8d450e8adb9955ad522e058 100644 (file)
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -11473,3 +11473,121 @@ rte_pmd_i40e_set_vf_tc_bw_alloc(uint8_t port, uint16_t vf_id,
 
        return 0;
 }
+
+int
+rte_pmd_i40e_set_vf_tc_max_bw(uint8_t port, uint16_t vf_id,
+                             uint8_t tc_no, uint32_t bw)
+{
+       struct rte_eth_dev *dev;
+       struct i40e_pf *pf;
+       struct i40e_vsi *vsi;
+       struct i40e_hw *hw;
+       struct i40e_aqc_configure_vsi_ets_sla_bw_data tc_bw;
+       int ret = 0;
+       int i;
+
+       RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
+
+       dev = &rte_eth_devices[port];
+
+       if (!is_device_supported(dev, &rte_i40e_pmd))
+               return -ENOTSUP;
+
+       pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
+
+       if (vf_id >= pf->vf_num || !pf->vfs) {
+               PMD_DRV_LOG(ERR, "Invalid VF ID.");
+               return -EINVAL;
+       }
+
+       vsi = pf->vfs[vf_id].vsi;
+       if (!vsi) {
+               PMD_DRV_LOG(ERR, "Invalid VSI.");
+               return -EINVAL;
+       }
+
+       if (bw > I40E_QOS_BW_MAX) {
+               PMD_DRV_LOG(ERR, "Bandwidth should not be larger than %dMbps.",
+                           I40E_QOS_BW_MAX);
+               return -EINVAL;
+       }
+
+       if (bw % I40E_QOS_BW_GRANULARITY) {
+               PMD_DRV_LOG(ERR, "Bandwidth should be the multiple of %dMbps.",
+                           I40E_QOS_BW_GRANULARITY);
+               return -EINVAL;
+       }
+
+       bw /= I40E_QOS_BW_GRANULARITY;
+
+       if (tc_no >= I40E_MAX_TRAFFIC_CLASS) {
+               PMD_DRV_LOG(ERR, "TC No. should be less than %d.",
+                           I40E_MAX_TRAFFIC_CLASS);
+               return -EINVAL;
+       }
+
+       hw = I40E_VSI_TO_HW(vsi);
+
+       if (!(vsi->enabled_tc & BIT_ULL(tc_no))) {
+               PMD_DRV_LOG(ERR, "VF %d TC %d isn't enabled.",
+                           vf_id, tc_no);
+               return -EINVAL;
+       }
+
+       /* No change. */
+       if (bw == vsi->bw_info.bw_ets_credits[tc_no]) {
+               PMD_DRV_LOG(INFO,
+                           "No change for TC max bandwidth. Nothing to do.");
+               return 0;
+       }
+
+       /**
+        * VF bandwidth limitation and TC bandwidth limitation cannot be
+        * enabled in parallel, disable VF bandwidth limitation if it's
+        * enabled.
+        * If bw is 0, means disable bandwidth limitation. Then no need to
+        * care about VF bandwidth limitation configuration.
+        */
+       if (bw && vsi->bw_info.bw_limit) {
+               ret = i40e_aq_config_vsi_bw_limit(hw, vsi->seid, 0, 0, NULL);
+               if (ret) {
+                       PMD_DRV_LOG(ERR,
+                                   "Failed to disable VF(%d)"
+                                   " bandwidth limitation, err(%d).",
+                                   vf_id, ret);
+                       return -EINVAL;
+               }
+
+               PMD_DRV_LOG(INFO,
+                           "VF max bandwidth is disabled according"
+                           " to TC max bandwidth setting.");
+       }
+
+       /**
+        * Get all the TCs' info to create a whole picture.
+        * Because the incremental change isn't permitted.
+        */
+       memset(&tc_bw, 0, sizeof(tc_bw));
+       tc_bw.tc_valid_bits = vsi->enabled_tc;
+       for (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {
+               if (vsi->enabled_tc & BIT_ULL(i)) {
+                       tc_bw.tc_bw_credits[i] =
+                               rte_cpu_to_le_16(
+                                       vsi->bw_info.bw_ets_credits[i]);
+               }
+       }
+       tc_bw.tc_bw_credits[tc_no] = rte_cpu_to_le_16((uint16_t)bw);
+
+       ret = i40e_aq_config_vsi_ets_sla_bw_limit(hw, vsi->seid, &tc_bw, NULL);
+       if (ret) {
+               PMD_DRV_LOG(ERR,
+                           "Failed to set VF %d TC %d max bandwidth, err(%d).",
+                           vf_id, tc_no, ret);
+               return -EINVAL;
+       }
+
+       /* Store the configuration. */
+       vsi->bw_info.bw_ets_credits[tc_no] = (uint16_t)bw;
+
+       return 0;
+}

diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h
index 9fdb447796d8ba4526d01103ce87718e63444283..08ee2b0033d515ce39e6cdda81d13c0c4866e05a 100644 (file)
--- a/drivers/net/i40e/rte_pmd_i40e.h
+++ b/drivers/net/i40e/rte_pmd_i40e.h
@@ -381,4 +381,26 @@ int rte_pmd_i40e_set_vf_tc_bw_alloc(uint8_t port,
                                    uint8_t tc_num,
                                    uint8_t *bw_weight);
 
+/**
+ * Set a specific TC's max bandwidth on a specific VF.
+ *
+ * @param port
+ *    The port identifier of the Ethernet device.
+ * @param vf_id
+ *    ID specifying VF.
+ * @param tc_no
+ *    Number specifying TC.
+ * @param bw
+ *    Max bandwidth for this TC.
+ * @return
+ *   - (0) if successful.
+ *   - (-ENODEV) if *port* invalid.
+ *   - (-EINVAL) if bad parameter.
+ *   - (-ENOTSUP) not supported by firmware.
+ */
+int rte_pmd_i40e_set_vf_tc_max_bw(uint8_t port,
+                                 uint16_t vf_id,
+                                 uint8_t tc_no,
+                                 uint32_t bw);
+
 #endif /* _PMD_I40E_H_ */

diff --git a/drivers/net/i40e/rte_pmd_i40e_version.map b/drivers/net/i40e/rte_pmd_i40e_version.map
index 85bc41da1ebdc12b33fc5720f3885588256fcf70..bd657ab559a9874fc1c6b7e3318585e86e4d3f29 100644 (file)
--- a/drivers/net/i40e/rte_pmd_i40e_version.map
+++ b/drivers/net/i40e/rte_pmd_i40e_version.map
@@ -28,5 +28,6 @@ DPDK_17.05 {
 
        rte_pmd_i40e_set_vf_max_bw;
        rte_pmd_i40e_set_vf_tc_bw_alloc;
+       rte_pmd_i40e_set_vf_tc_max_bw;
 
 } DPDK_17.02;