bus/ifpga: remove useless driver cast
authorThomas Monjalon <thomas@monjalon.net>
Tue, 25 Sep 2018 22:02:20 +0000 (00:02 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Thu, 27 Sep 2018 12:43:47 +0000 (14:43 +0200)
The rte_afu_driver is assigned to rte_afu_device.driver during probing.
There is no need of accessing the rte_afu_driver via rte_device.driver
and type casting to its container.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Rosen Xu <rosen.xu@intel.com>
drivers/bus/ifpga/ifpga_bus.c
drivers/bus/ifpga/rte_bus_ifpga.h

index b324872..c54b59d 100644 (file)
@@ -347,16 +347,14 @@ static int
 ifpga_remove_driver(struct rte_afu_device *afu_dev)
 {
        const char *name;
-       const struct rte_afu_driver *driver;
 
        name = rte_ifpga_device_name(afu_dev);
-       if (!afu_dev->device.driver) {
+       if (afu_dev->driver == NULL) {
                IFPGA_BUS_DEBUG("no driver attach to device %s\n", name);
                return 1;
        }
 
-       driver = RTE_DRV_TO_AFU_CONST(afu_dev->device.driver);
-       return driver->remove(afu_dev);
+       return afu_dev->driver->remove(afu_dev);
 }
 
 static int
index 51d5ae0..d53c0f4 100644 (file)
@@ -83,9 +83,6 @@ struct rte_afu_device {
 #define RTE_DEV_TO_AFU(ptr) \
        container_of(ptr, struct rte_afu_device, device)
 
-#define RTE_DRV_TO_AFU_CONST(ptr) \
-       container_of(ptr, const struct rte_afu_driver, driver)
-
 /**
  * Initialization function for the driver called during FPGA BUS probing.
  */