fbarray: fix detach in --no-shconf mode

In noshconf mode, no shared files are created, but we're still trying
to unlink them, resulting in detach/destroy failure even though it
should have succeeded. Fix it by exiting early in noshconf mode.

Fixes: 3ee2cde248a7 ("fbarray: support --no-shconf mode")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c
index 43caf3ced2c9dc653ea08b0a385de53319f8be1e..ba6c4ae39454923a7cc96f520a561771319411ea 100644 (file)
--- a/lib/librte_eal/common/eal_common_fbarray.c
+++ b/lib/librte_eal/common/eal_common_fbarray.c
@@ -878,6 +878,10 @@ rte_fbarray_destroy(struct rte_fbarray *arr)
        if (ret)
                return ret;
 
+       /* with no shconf, there were never any files to begin with */
+       if (internal_config.no_shconf)
+               return 0;
+
        /* try deleting the file */
        eal_get_fbarray_path(path, sizeof(path), arr->name);