net/ice/base: check number of chained recipes
authorWei Zhao <wei.zhao1@intel.com>
Fri, 10 Apr 2020 00:41:55 +0000 (08:41 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 21 Apr 2020 11:57:08 +0000 (13:57 +0200)
When we add some long switch rule, we need check the
number of final recipe number, if it is large than
ICE_MAX_CHAIN_RECIPE, we should refuse this rule.
For example:

"flow create 0 ingress pattern eth / ipv6
src is CDCD:910A:2222:5498:8475:1111:3900:1536
dst is CDCD:910A:2222:5498:8475:1111:3900:2022
tc is 3 / udp dst is 45 / end actions queue index 2 / end"

This rule will consume 6 recipe, if it is not refused, it
will cause the following code over write of lkup_indx and mask.

LIST_FOR_EACH_ENTRY(entry, &rm->rg_list, ice_recp_grp_entry,
l_entry) {
last_chain_entry->fv_idx[i] = entry->chain_idx;
buf[recps].content.lkup_indx[i] = entry->chain_idx;
buf[recps].content.mask[i++] = CPU_TO_LE16(0xFFFF);
..........
}

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Tested-by: Nannan Lu <nannan.lu@intel.com>
drivers/net/ice/base/ice_switch.c

index 07f8efd..7e7d748 100644 (file)
@@ -5352,6 +5352,9 @@ ice_add_sw_recipe(struct ice_hw *hw, struct ice_sw_recipe *rm,
                rm->n_grp_count++;
        }
 
+       if (rm->n_grp_count > ICE_MAX_CHAIN_RECIPE)
+               return ICE_ERR_MAX_LIMIT;
+
        tmp = (struct ice_aqc_recipe_data_elem *)ice_calloc(hw,
                                                            ICE_MAX_NUM_RECIPES,
                                                            sizeof(*tmp));