eal: fix build with gcc 9.0
authorFerruh Yigit <ferruh.yigit@intel.com>
Fri, 2 Nov 2018 19:06:06 +0000 (19:06 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Sun, 4 Nov 2018 21:48:04 +0000 (22:48 +0100)
build error:
In function ‘eal_plugin_add’,
    .../lib/librte_eal/common/eal_common_options.c:225:2:
    error: ‘strncpy’ output may be truncated copying 4095 bytes from a
           string of length 4095 [-Werror=stringop-truncation]
    strncpy(solib->name, path, PATH_MAX-1);

strncpy may result a not null-terminated string,
replaced it with strlcpy

Fixes: f9a08f650211 ("eal: add support for shared object drivers")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
lib/librte_eal/common/eal_common_options.c

index b82f3dd..e31eca5 100644 (file)
@@ -222,7 +222,7 @@ eal_plugin_add(const char *path)
                return -1;
        }
        memset(solib, 0, sizeof(*solib));
-       strncpy(solib->name, path, PATH_MAX-1);
+       strlcpy(solib->name, path, PATH_MAX-1);
        solib->name[PATH_MAX-1] = 0;
        TAILQ_INSERT_TAIL(&solib_list, solib, next);