net/dpaa2: warn on high Rx descriptor number
authorRohit Raj <rohit.raj@nxp.com>
Mon, 3 Jan 2022 10:01:17 +0000 (15:31 +0530)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 20 Jan 2022 15:24:08 +0000 (16:24 +0100)
Added warning message if application is configuring nb_desc
more than supported by PEB memory suggesting user to configure
HW descriptors in normal memory rather than in faster PEB
memory.

Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
drivers/net/dpaa2/dpaa2_ethdev.c

index 2b04f14..383fd57 100644 (file)
@@ -74,6 +74,9 @@ int dpaa2_timestamp_dynfield_offset = -1;
 /* Enable error queue */
 bool dpaa2_enable_err_queue;
 
+#define MAX_NB_RX_DESC         11264
+int total_nb_rx_desc;
+
 struct rte_dpaa2_xstats_name_off {
        char name[RTE_ETH_XSTATS_NAME_SIZE];
        uint8_t page_id; /* dpni statistics page id */
@@ -694,6 +697,13 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,
        DPAA2_PMD_DEBUG("dev =%p, queue =%d, pool = %p, conf =%p",
                        dev, rx_queue_id, mb_pool, rx_conf);
 
+       total_nb_rx_desc += nb_rx_desc;
+       if (total_nb_rx_desc > MAX_NB_RX_DESC) {
+               DPAA2_PMD_WARN("\nTotal nb_rx_desc exceeds %d limit. Please use Normal buffers",
+                              MAX_NB_RX_DESC);
+               DPAA2_PMD_WARN("To use Normal buffers, run 'export DPNI_NORMAL_BUF=1' before running dynamic_dpl.sh script");
+       }
+
        /* Rx deferred start is not supported */
        if (rx_conf->rx_deferred_start) {
                DPAA2_PMD_ERR("%p:Rx deferred start not supported",
@@ -984,6 +994,9 @@ dpaa2_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t rx_queue_id)
 
        memset(&cfg, 0, sizeof(struct dpni_queue));
        PMD_INIT_FUNC_TRACE();
+
+       total_nb_rx_desc -= dpaa2_q->nb_desc;
+
        if (dpaa2_q->cgid != 0xff) {
                options = DPNI_QUEUE_OPT_CLEAR_CGID;
                cfg.cgid = dpaa2_q->cgid;