net/ice: fix VLAN filter Tx
authorQiming Yang <qiming.yang@intel.com>
Mon, 14 Jan 2019 13:35:30 +0000 (21:35 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 14 Jan 2019 16:44:29 +0000 (17:44 +0100)
This patch fixed Tx error and allowed untagged packets in
when vlan filter on.

Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops")

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
drivers/net/ice/ice_ethdev.c

index 5545f38..b145d9c 100644 (file)
@@ -2183,14 +2183,20 @@ ice_vsi_config_vlan_filter(struct ice_vsi *vsi, bool on)
        if (ret) {
                PMD_DRV_LOG(INFO, "Update VSI failed to %s vlan rx pruning",
                            on ? "enable" : "disable");
-               ret = -EINVAL;
+               return -EINVAL;
        } else {
                vsi->info.valid_sections |=
                        rte_cpu_to_le_16(ICE_AQ_VSI_PROP_SW_VALID |
                                         ICE_AQ_VSI_PROP_SECURITY_VALID);
        }
 
-       return ret;
+       /* consist with other drivers, allow untagged packet when vlan filter on */
+       if (on)
+               ret = ice_add_vlan_filter(vsi, 0);
+       else
+               ret = ice_remove_vlan_filter(vsi, 0);
+
+       return 0;
 }
 
 static int