net/mlx5: use anonymous Direct Verbs allocator argument
authorMichael Baum <michaelba@mellanox.com>
Wed, 24 Jun 2020 13:46:41 +0000 (13:46 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 30 Jun 2020 12:52:30 +0000 (14:52 +0200)
The mlx5_dev_spawn function defines an struct mlx5dv_ctx_allocators type
variable several hundred rows after it starts, with the only use it
being passed as a parameter to the mlx5_glue->dv_set_context_attr
function.
However, according to DPDK Coding Style Guidelines, variables should be
declared at the start of a block of code rather than in the middle.
Therefore, to improve the Coding Style, the variable is passed directly
to the function without declaring it before.

Signed-off-by: Michael Baum <michaelba@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
drivers/net/mlx5/linux/mlx5_os.c

index f0147e6..2dc57b2 100644 (file)
@@ -988,14 +988,13 @@ err_secondary:
        TAILQ_INIT(&priv->flow_meters);
        TAILQ_INIT(&priv->flow_meter_profiles);
        /* Hint libmlx5 to use PMD allocator for data plane resources */
-       struct mlx5dv_ctx_allocators alctr = {
-               .alloc = &mlx5_alloc_verbs_buf,
-               .free = &mlx5_free_verbs_buf,
-               .data = priv,
-       };
        mlx5_glue->dv_set_context_attr(sh->ctx,
-                                      MLX5DV_CTX_ATTR_BUF_ALLOCATORS,
-                                      (void *)((uintptr_t)&alctr));
+                       MLX5DV_CTX_ATTR_BUF_ALLOCATORS,
+                       (void *)((uintptr_t)&(struct mlx5dv_ctx_allocators){
+                               .alloc = &mlx5_alloc_verbs_buf,
+                               .free = &mlx5_free_verbs_buf,
+                               .data = priv,
+                       }));
        /* Bring Ethernet device up. */
        DRV_LOG(DEBUG, "port %u forcing Ethernet interface up",
                eth_dev->data->port_id);