net/ice/base: remove unnecessary conditional
authorQi Zhang <qi.z.zhang@intel.com>
Mon, 7 Sep 2020 11:06:51 +0000 (19:06 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 18 Sep 2020 16:55:10 +0000 (18:55 +0200)
These two conditional statements are unnecessary because the condition
is always true based on existing code flow.  Remove them to resolve
potential errors from some static analysis tools.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Qiming Yang <qiming.yang@intel.com>
drivers/net/ice/base/ice_flow.c

index 1f621ca..cd3ce82 100644 (file)
@@ -1089,7 +1089,7 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
                 */
                if (fld == ICE_FLOW_FIELD_IDX_IPV4_TTL)
                        sib = ICE_FLOW_FIELD_IDX_IPV4_PROT;
-               else if (fld == ICE_FLOW_FIELD_IDX_IPV4_PROT)
+               else
                        sib = ICE_FLOW_FIELD_IDX_IPV4_TTL;
 
                /* If the sibling field is also included, that field's
@@ -1108,7 +1108,7 @@ ice_flow_xtract_fld(struct ice_hw *hw, struct ice_flow_prof_params *params,
                 */
                if (fld == ICE_FLOW_FIELD_IDX_IPV6_TTL)
                        sib = ICE_FLOW_FIELD_IDX_IPV6_PROT;
-               else if (fld == ICE_FLOW_FIELD_IDX_IPV6_PROT)
+               else
                        sib = ICE_FLOW_FIELD_IDX_IPV6_TTL;
 
                /* If the sibling field is also included, that field's