net/hns3: fix VF mailbox head field
authorChengwen Feng <fengchengwen@huawei.com>
Wed, 31 Mar 2021 10:01:41 +0000 (18:01 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 8 Apr 2021 16:57:09 +0000 (18:57 +0200)
Currently, the VF mailbox synchronization communication is based on
three fields: head/tail/lost, when head equals tail plus lost, it
means the response is received successfully.

The head field indicates the number of requests that are successfully
sent. If the request sending fails, it should not be updated.

This patch fix the above bug by roll back updates when the sending
fails.

Fixes: 463e748964f5 ("net/hns3: support mailbox")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
drivers/net/hns3/hns3_mbx.c

index 499285d..8ea8998 100644 (file)
@@ -142,6 +142,7 @@ hns3_send_mbx_msg(struct hns3_hw *hw, uint16_t code, uint16_t subcode,
                hw->mbx_resp.head++;
                ret = hns3_cmd_send(hw, &desc, 1);
                if (ret) {
+                       hw->mbx_resp.head--;
                        rte_spinlock_unlock(&hw->mbx_resp.lock);
                        hns3_err(hw, "VF failed(=%d) to send mbx message to PF",
                                 ret);