net/ixgbe/base: change endianness of PHY data
authorXiao Wang <xiao.w.wang@intel.com>
Sun, 25 Sep 2016 08:59:40 +0000 (16:59 +0800)
committerBruce Richardson <bruce.richardson@intel.com>
Fri, 30 Sep 2016 10:27:18 +0000 (12:27 +0200)
The x550a related firmware reverses the endianness of the PHY data read
and written via host interface command, so make corresponding changes
to that.

Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
drivers/net/ixgbe/base/ixgbe_osdep.h
drivers/net/ixgbe/base/ixgbe_type.h
drivers/net/ixgbe/base/ixgbe_x550.c

index 06d1ee1..77f0af5 100644 (file)
@@ -100,6 +100,7 @@ enum {
 #define IXGBE_LE32_TO_CPUS(_i) rte_le_to_cpu_32(_i)
 #define IXGBE_CPU_TO_BE16(_i)  rte_cpu_to_be_16(_i)
 #define IXGBE_CPU_TO_BE32(_i)  rte_cpu_to_be_32(_i)
+#define IXGBE_BE32_TO_CPU(_i)  rte_be_to_cpu_32(_i)
 
 typedef uint8_t                u8;
 typedef int8_t         s8;
index 83818a9..b2fdfcd 100644 (file)
@@ -3136,13 +3136,13 @@ struct ixgbe_hic_internal_phy_req {
        u8 command_type;
        __be16 address;
        u16 rsv1;
-       __le32 write_data;
+       __be32 write_data;
        u16 pad;
 };
 
 struct ixgbe_hic_internal_phy_resp {
        struct ixgbe_hic_hdr hdr;
-       __le32 read_data;
+       __be32 read_data;
 };
 
 #ifdef C99
index b8fdb00..2c80a9b 100644 (file)
@@ -1278,7 +1278,7 @@ s32 ixgbe_write_iosf_sb_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
        write_cmd.port_number = hw->bus.lan_id;
        write_cmd.command_type = FW_INT_PHY_REQ_WRITE;
        write_cmd.address = IXGBE_CPU_TO_BE16(reg_addr);
-       write_cmd.write_data = IXGBE_CPU_TO_LE32(data);
+       write_cmd.write_data = IXGBE_CPU_TO_BE32(data);
 
        status = ixgbe_host_interface_command(hw, (u32 *)&write_cmd,
                                              sizeof(write_cmd),
@@ -1318,7 +1318,7 @@ s32 ixgbe_read_iosf_sb_reg_x550a(struct ixgbe_hw *hw, u32 reg_addr,
                                              IXGBE_HI_COMMAND_TIMEOUT, true);
 
        /* Extract the register value from the response. */
-       *data = IXGBE_LE32_TO_CPU(hic.rsp.read_data);
+       *data = IXGBE_BE32_TO_CPU(hic.rsp.read_data);
 
        return status;
 }