net/ena: disable ops not supported by secondary process
authorStanislaw Kardach <kda@semihalf.com>
Wed, 12 May 2021 10:13:46 +0000 (12:13 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 12 May 2021 12:19:03 +0000 (14:19 +0200)
For dev_ops not supported by the secondary process, either return -EPERM
or return without doing anything. In both cases log a warning.

It's still application's responsibility to avoid calls like that and
those changes are for debugging/informational purposes.

Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
Reviewed-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@amazon.com>
Reviewed-by: Shay Agroskin <shayagr@amazon.com>
drivers/net/ena/ena_ethdev.c

index e310e7a..dfe6827 100644 (file)
@@ -535,6 +535,12 @@ ena_dev_reset(struct rte_eth_dev *dev)
 {
        int rc = 0;
 
+       /* Cannot release memory in secondary process */
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               PMD_DRV_LOG(WARNING, "dev_reset not supported in secondary.\n");
+               return -EPERM;
+       }
+
        ena_destroy_device(dev);
        rc = eth_ena_dev_init(dev);
        if (rc)
@@ -1059,6 +1065,12 @@ static int ena_start(struct rte_eth_dev *dev)
        uint64_t ticks;
        int rc = 0;
 
+       /* Cannot allocate memory in secondary process */
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               PMD_DRV_LOG(WARNING, "dev_start not supported in secondary.\n");
+               return -EPERM;
+       }
+
        rc = ena_check_valid_conf(adapter);
        if (rc)
                return rc;
@@ -1105,6 +1117,12 @@ static int ena_stop(struct rte_eth_dev *dev)
        struct ena_com_dev *ena_dev = &adapter->ena_dev;
        int rc;
 
+       /* Cannot free memory in secondary process */
+       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
+               PMD_DRV_LOG(WARNING, "dev_stop not supported in secondary.\n");
+               return -EPERM;
+       }
+
        rte_timer_stop_sync(&adapter->timer_wd);
        ena_queue_stop_all(dev, ENA_RING_TYPE_TX);
        ena_queue_stop_all(dev, ENA_RING_TYPE_RX);