net/mlx5: reject copy to mark via modify action

The Mark action is a two-stage process in the Mellanox driver.
First, a hardware register is filled with the required value,
then this value is registered in the software resource table.

The MODIFY_FIELD action can instruct a Mellanox NIC to copy
some value from an arbitrary packet header field into the
hardware register, associated with the Mark item. But there
is no way NIC can modify the software resource table as well.

Due to these driver limitations the copying of arbitrary value
to the MARK can not be supported and should be rejected in the
MODIFY_FIELD action.

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 1e49d7019a9eb2fc6ca792265979ff7ac1fdfe6d..736227bc0c8fb96305971fba7d12e2227500fa93 100644 (file)
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -4944,10 +4944,11 @@ flow_dv_validate_action_modify_field(struct rte_eth_dev *dev,
                                "source and destination fields"
                                " cannot be the same");
        if (action_modify_field->dst.field == RTE_FLOW_FIELD_VALUE ||
-           action_modify_field->dst.field == RTE_FLOW_FIELD_POINTER)
+           action_modify_field->dst.field == RTE_FLOW_FIELD_POINTER ||
+           action_modify_field->dst.field == RTE_FLOW_FIELD_MARK)
                return rte_flow_error_set(error, EINVAL,
                                RTE_FLOW_ERROR_TYPE_ACTION, action,
-                               "immediate value or a pointer to it"
+                               "mark, immediate value or a pointer to it"
                                " cannot be used as a destination");
        if (action_modify_field->dst.field == RTE_FLOW_FIELD_START ||
            action_modify_field->src.field == RTE_FLOW_FIELD_START)