net/vmxnet3: keep link state consistent
authorChas Williams <chas3@att.com>
Sun, 18 Mar 2018 01:45:52 +0000 (21:45 -0400)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 27 Apr 2018 14:54:56 +0000 (15:54 +0100)
The vmxnet3 never attempts link speed negotiation.  As a virtual device
the link speed is vague at best.  However, it is important for certain
applications, like bonding, to see a consistent link_status.  802.3ad
requires that only links of the same cost (link speed) be enslaved.
Keeping the link status consistent in vmxnet3 avoids races with bonding
enslavement.

Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
Cc: stable@dpdk.org
Signed-off-by: Chas Williams <chas3@att.com>
Acked-by: Yong Wang <yongwang@vmware.com>
drivers/net/vmxnet3/vmxnet3_ethdev.c

index 4568521..19f0325 100644 (file)
@@ -1105,7 +1105,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev,
                link.link_status = ETH_LINK_UP;
        link.link_duplex = ETH_LINK_FULL_DUPLEX;
        link.link_speed = ETH_SPEED_NUM_10G;
-       link.link_autoneg = ETH_LINK_AUTONEG;
+       link.link_autoneg = ETH_LINK_FIXED;
 
        return rte_eth_linkstatus_set(dev, &link);
 }