net/softnic: fix memory illegal access after free

While deleting the elements from the linked list, TAILQ_FOREACH causes
read from the freed pointer. Fixes the issue by using TAILQ_FOREACH_SAFE
instead.

Coverity issue: 302867
Fixes: bef50bcb1c47 ("net/softnic: implement start and stop")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

diff --git a/drivers/net/softnic/rte_eth_softnic_swq.c b/drivers/net/softnic/rte_eth_softnic_swq.c
index 1944fbbfd68280346a836f0171828bf916815da6..2083d0a976a6ce822a4641d7c9c0e29d8cd694ae 100644 (file)
--- a/drivers/net/softnic/rte_eth_softnic_swq.c
+++ b/drivers/net/softnic/rte_eth_softnic_swq.c
@@ -6,6 +6,7 @@
 #include <string.h>
 
 #include <rte_string_fns.h>
+#include <rte_tailq.h>
 
 #include "rte_eth_softnic_internals.h"
 
@@ -36,9 +37,9 @@ softnic_swq_free(struct pmd_internals *p)
 void
 softnic_softnic_swq_free_keep_rxq_txq(struct pmd_internals *p)
 {
-       struct softnic_swq *swq;
+       struct softnic_swq *swq, *tswq;
 
-       TAILQ_FOREACH(swq, &p->swq_list, node) {
+       TAILQ_FOREACH_SAFE(swq, &p->swq_list, node, tswq) {
                if ((strncmp(swq->name, "RXQ", strlen("RXQ")) == 0) ||
                        (strncmp(swq->name, "TXQ", strlen("TXQ")) == 0))
                        continue;