app/testpmd: fix invalid port detaching
authorMatan Azrad <matan@mellanox.com>
Tue, 12 Nov 2019 08:47:39 +0000 (08:47 +0000)
committerDavid Marchand <david.marchand@redhat.com>
Wed, 20 Nov 2019 23:18:02 +0000 (00:18 +0100)
The port was not validated before detaching.

Ignore port detach operation when the port is not valid.

Fixes: f8e5baa2662d ("app/testpmd: check not detaching device twice")
Cc: stable@dpdk.org
Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
app/test-pmd/testpmd.c

index 446da36..73ebf37 100644 (file)
@@ -2557,6 +2557,9 @@ detach_port_device(portid_t port_id)
 
        printf("Removing a device...\n");
 
+       if (port_id_is_invalid(port_id, ENABLED_WARN))
+               return;
+
        dev = rte_eth_devices[port_id].device;
        if (dev == NULL) {
                printf("Device already removed\n");