net/bonding: fix socket ID check
authorDavid Marchand <david.marchand@redhat.com>
Tue, 16 Jun 2020 09:46:37 +0000 (11:46 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Sat, 11 Jul 2020 04:18:53 +0000 (06:18 +0200)
Caught by code review, rte_eth_dev_socket_id() returns -1 on error.
The code should behave the same, but still, do not use LCORE_ID_ANY for
something that is not a lcore id.

Fixes: c15c5897340d ("net/bonding: avoid allocating mempool on unknown socket")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Chas Williams <chas3@att.com>
drivers/net/bonding/rte_eth_bond_8023ad.c

index b77a37d..b7ffa2f 100644 (file)
@@ -1043,7 +1043,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,
        RTE_ASSERT(port->tx_ring == NULL);
 
        socket_id = rte_eth_dev_socket_id(slave_id);
-       if (socket_id == (int)LCORE_ID_ANY)
+       if (socket_id == -1)
                socket_id = rte_socket_id();
 
        element_size = sizeof(struct slow_protocol_frame) +