bus/fpga: use strlcpy instead of strncpy
authorPablo de Lara <pablo.de.lara.guarch@intel.com>
Sat, 12 May 2018 07:02:17 +0000 (08:02 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Sun, 13 May 2018 10:06:01 +0000 (12:06 +0200)
Gcc 8 reports a build error:

drivers/bus/ifpga/ifpga_bus.c:161:2: error: ‘strncpy’ specified
bound 256 equals destination size [-Werror=stringop-truncation]
  strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
drivers/bus/ifpga/ifpga_bus.c

index 16b7e06..45597a1 100644 (file)
 #include <rte_memzone.h>
 #include <rte_eal.h>
 #include <rte_common.h>
-
 #include <rte_devargs.h>
 #include <rte_kvargs.h>
 #include <rte_alarm.h>
+#include <rte_string_fns.h>
 
 #include "rte_rawdev.h"
 #include "rte_rawdev_pmd.h"
@@ -158,7 +158,7 @@ ifpga_scan_one(struct rte_rawdev *rawdev,
                rawdev->dev_ops->dev_start(rawdev))
                goto free_dev;
 
-       strncpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
+       strlcpy(afu_pr_conf.bs_path, path, sizeof(afu_pr_conf.bs_path));
        if (rawdev->dev_ops->firmware_load &&
                rawdev->dev_ops->firmware_load(rawdev,
                                &afu_pr_conf)){