net/i40e: remove redundant statement and braces
authorYong Wang <wang.yong19@zte.com.cn>
Mon, 9 Jan 2017 13:48:52 +0000 (08:48 -0500)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 17 Jan 2017 18:41:42 +0000 (19:41 +0100)
In function "reassemble_packets()", the statement "end = secondlast;"
is redundant since there is another assignment "start = end = NULL;"
3 lines below. BTW, I removed the redundant braces in the conditional
statement "if (end->data_len > rxq->crc_len)".

Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
drivers/net/i40e/i40e_rxtx_vec_common.h

index 990520f..3745558 100644 (file)
@@ -65,9 +65,9 @@ reassemble_packets(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_bufs,
                                start->ol_flags = end->ol_flags;
                                /* we need to strip crc for the whole packet */
                                start->pkt_len -= rxq->crc_len;
-                               if (end->data_len > rxq->crc_len) {
+                               if (end->data_len > rxq->crc_len)
                                        end->data_len -= rxq->crc_len;
-                               else {
+                               else {
                                        /* free up last mbuf */
                                        struct rte_mbuf *secondlast = start;
 
@@ -78,7 +78,6 @@ reassemble_packets(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_bufs,
                                                        end->data_len);
                                        secondlast->next = NULL;
                                        rte_pktmbuf_free_seg(end);
-                                       end = secondlast;
                                }
                                pkts[pkt_idx++] = start;
                                start = end = NULL;