mempool/octeontx: fix error handling in initialization

When octeontx_get_fpavf fails fpa pointer is used to get
pool_stack_base, which is then freed.

Coverity issue: 351263
Fixes: 9bc692f83baa ("mempool/octeontx: add application domain validation")
Cc: stable@dpdk.org
Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>

diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
index c97267d..63f8fb3 100644 (file)
--- a/drivers/mempool/octeontx/octeontx_fpavf.c
+++ b/drivers/mempool/octeontx/octeontx_fpavf.c
@@ -305,10 +305,8 @@ octeontx_fpapf_pool_destroy(unsigned int gpool_index)
        int ret = -1;
 
        fpa = octeontx_get_fpavf(gpool_index);
-       if (fpa == NULL) {
-               ret = -EINVAL;
-               goto err;
-       }
+       if (fpa == NULL)
+               return -EINVAL;
 
        hdr.coproc = FPA_COPROC;
        hdr.msg = FPA_CONFIGSET;