test/flow_classify: fix return types
authorReshma Pattan <reshma.pattan@intel.com>
Tue, 17 Jul 2018 16:44:45 +0000 (17:44 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Thu, 26 Jul 2018 19:42:41 +0000 (21:42 +0200)
UTs should return either TEST_SUCCESS or TEST_FAILED only.
They should not return 0, -1 and any other value.

Fixes: 9c9befea4f ("test: add flow classify unit tests")
CC: stable@dpdk.org
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
test/test/test_flow_classify.c

index fc83b69..5f5beee 100644 (file)
@@ -871,32 +871,32 @@ test_flow_classify(void)
                printf("Line %i: f_create has failed!\n", __LINE__);
                rte_flow_classifier_free(cls->cls);
                rte_free(cls);
-               return -1;
+               return TEST_FAILED;
        }
        printf("Created table_acl for for IPv4 five tuple packets\n");
 
        ret = init_mbufpool();
        if (ret) {
                printf("Line %i: init_mbufpool has failed!\n", __LINE__);
-               return -1;
+               return TEST_FAILED;
        }
 
        if (test_invalid_parameters() < 0)
-               return -1;
+               return TEST_FAILED;
        if (test_valid_parameters() < 0)
-               return -1;
+               return TEST_FAILED;
        if (test_invalid_patterns() < 0)
-               return -1;
+               return TEST_FAILED;
        if (test_invalid_actions() < 0)
-               return -1;
+               return TEST_FAILED;
        if (test_query_udp() < 0)
-               return -1;
+               return TEST_FAILED;
        if (test_query_tcp() < 0)
-               return -1;
+               return TEST_FAILED;
        if (test_query_sctp() < 0)
-               return -1;
+               return TEST_FAILED;
 
-       return 0;
+       return TEST_SUCCESS;
 }
 
 REGISTER_TEST_COMMAND(flow_classify_autotest, test_flow_classify);