net/hns3: fix unintended sign extension in dump operation
authorHongbo Zheng <zhenghongbo3@huawei.com>
Tue, 9 Jun 2020 08:44:17 +0000 (16:44 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 16 Jun 2020 17:21:07 +0000 (19:21 +0200)
There are coverity defects related "Unintended sign extension" in the
internal static function named hns3_get_regs_length used for dumping reg
operation.

This patch fixes them by replacing the data type of cmdq_lines,
common_lines, ring_lines and tqp_intr_lines with uint32_t in the inner
static function named hns3_get_regs_length of hns3 PMD driver.

Coverity issue: 349917, 349914
Fixes: 936eda25e8da ("net/hns3: support dump register")
Cc: stable@dpdk.org
Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
drivers/net/hns3/hns3_regs.c

index a3f2a51..63c8602 100644 (file)
@@ -116,7 +116,7 @@ static int
 hns3_get_regs_length(struct hns3_hw *hw, uint32_t *length)
 {
        struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
-       int cmdq_lines, common_lines, ring_lines, tqp_intr_lines;
+       uint32_t cmdq_lines, common_lines, ring_lines, tqp_intr_lines;
        uint32_t regs_num_32_bit, regs_num_64_bit;
        uint32_t len;
        int ret;