net/bnxt: check PCI config read
authorAjit Khaparde <ajit.khaparde@broadcom.com>
Fri, 30 Apr 2021 20:14:11 +0000 (13:14 -0700)
committerAjit Khaparde <ajit.khaparde@broadcom.com>
Sun, 2 May 2021 22:17:17 +0000 (00:17 +0200)
Return value where return value of rte_pci_read_config was not checked.
Fix it.

Coverity issue: 349919
Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
drivers/net/bnxt/bnxt_ethdev.c

index 115acda..719eb68 100644 (file)
@@ -4159,13 +4159,17 @@ uint32_t bnxt_read_fw_status_reg(struct bnxt *bp, uint32_t index)
        struct bnxt_error_recovery_info *info = bp->recovery_info;
        uint32_t reg = info->status_regs[index];
        uint32_t type, offset, val = 0;
+       int ret = 0;
 
        type = BNXT_FW_STATUS_REG_TYPE(reg);
        offset = BNXT_FW_STATUS_REG_OFF(reg);
 
        switch (type) {
        case BNXT_FW_STATUS_REG_TYPE_CFG:
-               rte_pci_read_config(bp->pdev, &val, sizeof(val), offset);
+               ret = rte_pci_read_config(bp->pdev, &val, sizeof(val), offset);
+               if (ret < 0)
+                       PMD_DRV_LOG(ERR, "Failed to read PCI offset %#x",
+                                   offset);
                break;
        case BNXT_FW_STATUS_REG_TYPE_GRC:
                offset = info->mapped_status_regs[index];