]> git.droids-corp.org - dpdk.git/commitdiff
net/hns3: fix PTP capability report
authorChengwen Feng <fengchengwen@huawei.com>
Tue, 13 Apr 2021 11:50:08 +0000 (19:50 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 14 Apr 2021 17:45:27 +0000 (19:45 +0200)
The PTP depends on special packet type reported by hardware which
enabled rxd advanced layout, so if the hardware doesn't support rxd
advanced layout, driver should ignore the PTP capability.

Fixes: 438752358158 ("net/hns3: get device capability from firmware")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
drivers/net/hns3/hns3_cmd.c

index df167f1da25a821d7077a3d2ac58ff7e10c3d97d..b571999be28917d5db82e3ba29e75d46d9b49cb8 100644 (file)
@@ -422,8 +422,19 @@ hns3_parse_capability(struct hns3_hw *hw,
        if (hns3_get_bit(caps, HNS3_CAPS_FD_QUEUE_REGION_B))
                hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B,
                             1);
-       if (hns3_get_bit(caps, HNS3_CAPS_PTP_B))
-               hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_PTP_B, 1);
+       if (hns3_get_bit(caps, HNS3_CAPS_PTP_B)) {
+               /*
+                * PTP depends on special packet type reported by hardware which
+                * enabled rxd advanced layout, so if the hardware doesn't
+                * support rxd advanced layout, driver should ignore the PTP
+                * capability.
+                */
+               if (hns3_get_bit(caps, HNS3_CAPS_RXD_ADV_LAYOUT_B))
+                       hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_PTP_B, 1);
+               else
+                       hns3_warn(hw, "ignore PTP capability due to lack of "
+                                 "rxd advanced layout capability.");
+       }
        if (hns3_get_bit(caps, HNS3_CAPS_TX_PUSH_B))
                hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_TX_PUSH_B, 1);
        if (hns3_get_bit(caps, HNS3_CAPS_PHY_IMP_B))