net/e1000/base: remove useless statement
authorGuinan Sun <guinanx.sun@intel.com>
Mon, 6 Jul 2020 08:12:12 +0000 (08:12 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 7 Jul 2020 21:38:27 +0000 (23:38 +0200)
As it stands now, this fix will not change the current functionality
of the code. In addition, we remove the comment that seemed to be
a copy/paste from a separate implementation.

Signed-off-by: Jeb Cramer <jeb.j.cramer@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
Reviewed-by: Wei Zhao <wei.zhao1@intel.com>
drivers/net/e1000/base/e1000_ich8lan.c

index b79e3ba..9b9cc7d 100644 (file)
@@ -4113,13 +4113,6 @@ STATIC s32 e1000_update_nvm_checksum_spt(struct e1000_hw *hw)
        if (ret_val)
                goto release;
 
-       /* And invalidate the previously valid segment by setting
-        * its signature word (0x13) high_byte to 0b. This can be
-        * done without an erase because flash erase sets all bits
-        * to 1's. We can write 1's to 0's without an erase
-        */
-       act_offset = (old_bank_offset + E1000_ICH_NVM_SIG_WORD) * 2 + 1;
-
        /* offset in words but we read dword*/
        act_offset = old_bank_offset + E1000_ICH_NVM_SIG_WORD - 1;
        ret_val = e1000_read_flash_dword_ich8lan(hw, act_offset, &dword);